StopIteration & RuntimeError fix for Python >= 3.7#294
Open
NicolasBizzozzero wants to merge 2 commits intoclips:masterfrom
Open
StopIteration & RuntimeError fix for Python >= 3.7#294NicolasBizzozzero wants to merge 2 commits intoclips:masterfrom
NicolasBizzozzero wants to merge 2 commits intoclips:masterfrom
Conversation
StopIteration & RuntimeError fix for Python >= 3.7
|
Thank you for all the work @NicolasBizzozzero ! Seems like the CI build is based on python=3.6 and causing the check failures? Who can help to fix this issue as it seems stupid to not able to fix this for quite a while... |
|
Meanwhile you can monkey patch around this issue by calling this method in your module: def patch_pattern():
from pattern import text
original_read = text._read
@functools.wraps(original_read)
def patched_read(*args, **kwargs):
try:
for r in original_read(*args, **kwargs):
yield r
except RuntimeError:
pass
text._read = patched_read |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Python 3.7, all StopIteration exceptions raised inside a generator are transformed into RuntimeError (see PEP-0479 and this answer from StackOverflow). This new behavior made pattern unusable for all Python3.7+ users and all packages depending on it (gensim for instance: piskvorky/gensim#2438).
This PR fixes the _read generator by removing the StopIteration exception raised in it. It solves the following issues :